Skip to content

Emit assignment-from-none for builtin methods like dict.update()#8809

Merged
jacobtylerwalls merged 3 commits into
pylint-dev:mainfrom
jacobtylerwalls:assignment-from-none
Jul 1, 2023
Merged

Emit assignment-from-none for builtin methods like dict.update()#8809
jacobtylerwalls merged 3 commits into
pylint-dev:mainfrom
jacobtylerwalls:assignment-from-none

Conversation

@jacobtylerwalls
Copy link
Copy Markdown
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes #8714

@jacobtylerwalls jacobtylerwalls added the False Negative 🦋 No message is emitted but something is wrong with the code label Jul 1, 2023
@jacobtylerwalls jacobtylerwalls added this to the 3.0.0a7 milestone Jul 1, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2023

Codecov Report

Merging #8809 (69dac2d) into main (1da5183) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8809   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         173      173           
  Lines       18510    18511    +1     
=======================================
+ Hits        17750    17751    +1     
  Misses        760      760           
Impacted Files Coverage Δ
pylint/checkers/typecheck.py 96.46% <100.00%> (+<0.01%) ⬆️

@github-actions

This comment has been minimized.

Comment thread pylint/checkers/typecheck.py Outdated
@jacobtylerwalls jacobtylerwalls enabled auto-merge (squash) July 1, 2023 15:38
@jacobtylerwalls jacobtylerwalls merged commit 32effc5 into pylint-dev:main Jul 1, 2023
@jacobtylerwalls jacobtylerwalls deleted the assignment-from-none branch July 1, 2023 16:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2023

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 69dac2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

False Negative 🦋 No message is emitted but something is wrong with the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False negative assigned-from-none for value = dict.update({}, {})

2 participants